Truncate checkpoint when final connection drops to match sqlite behavior #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
requested review from
jussisaurio,
penberg and
pereman2
as code owners
Contributor
|
I think, this closes #3729, haven't checked locally but from pr description. or i misunderstood this - in that case, ignore this. |
PThorpe92
force-pushed
the
checkpoint_on_drop
branch
from
973e4ac to
25dd5d1
Compare
jussisaurio
approved these changes
Nov 17, 2025
Collaborator
|
I reran |
jussisaurio
requested changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone noticed they have an 8GB WAL file after using turso in a daemon which is constantly restarted. SQLite will truncate checkpoint the log automatically when the final connection to a database drops. We do this currently, but only when
closeis explicitly called.Otherwise this is quite problematic because we read the entire WAL into the frame cache on startup every time.